refactor: simplify Controller request interception

In multi-user mode if Alice attempts to access /~bob/ she would get an
Unauthorized error since branches are private.  To improve the UX we
instead already showed Alice a list of which files Bob has shared with
her. Previously this was achieved with an before_return_error hook
in the Controller trait.

While this worked fine, it wasn't elegant, since it required passing
the Context struct in all Unauthorized errors, so that the
before_return_error hook could access the context.

This commit refactors the code to intercept requests to paths like
/~bob/ before the regular request handling instead of afterwards.

While this could have been implemented in the before_route hook, this
would have required either invoking parse_url_path a second time or
passing the Result of parse_url_path, both of which would be akward.
Therefore this commit also merges before_route into parse_url_path.

1 files changed, 1 insertions, 3 deletions

diff --git a/src/error.rs b/src/error.rs
index c006255..8460376 100644
--- a/src/error.rs
+++ b/src/error.rs
@@ -2,13 +2,11 @@ use sputnik::hyper_body::FormError;
 use sputnik::request::QueryError;
 use std::str::Utf8Error;
 
-use crate::Context;
-
 pub enum Error {
     /// A 400 bad request error.
     BadRequest(String),
     /// A 401 unauthorized error.
-    Unauthorized(String, Context),
+    Unauthorized(String),
     /// A 403 forbidden error.
     Forbidden(String),
     /// A 404 not found error.