diff options
| author | Martin Fischer <martin@push-f.com> | 2023-09-27 08:05:58 +0200 |
|---|---|---|
| committer | Martin Fischer <martin@push-f.com> | 2023-09-28 10:36:08 +0200 |
| commit | 3c89744824ea6b8b32d82c2c37ac1de6d980709c (patch) | |
| tree | f09c32d629507af4ae99b05bd9629cffeba879bc /CHANGELOG.md | |
| parent | c75dce875cff03e59ec7b6bceed4ec63283a6477 (diff) | |
break!: make AttributeMap::get return Option<&str>
Most of the time you'll only be interested in the attribute value,
so the `get` method should directly return it instead of a wrapper type.
This also makes the API more predictable since e.g. the DOM getAttribute
method also returns a string. Lastly previously it was quite confusing
that map[key] wasn't equivalent to map.get(key).unwrap().
Diffstat (limited to 'CHANGELOG.md')
| -rw-r--r-- | CHANGELOG.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 3f175d7..f48b124 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,6 +45,10 @@ * Removed `CdataAction` and changed `handle_cdata_open` to just take a boolean instead. +* `AttributeMap::get` now just returns `Option<&str>` as you would expect. + To obtain the value and attribute trace, you now have to use the + newly added `AttributeMap::value_and_trace_idx` method. + * Three variants of the `State` enum have been renamed according to the Rust API guidelines (`RcData` to `Rcdata`, `RawText` to `Rawtext` and `PlainText` to `Plaintext`). |