diff options
| author | Martin Fischer <martin@push-f.com> | 2023-08-29 07:24:55 +0200 |
|---|---|---|
| committer | Martin Fischer <martin@push-f.com> | 2023-09-28 10:36:08 +0200 |
| commit | df5a2ae14c4976d404195e83e52b8db62be63988 (patch) | |
| tree | 5260ba3196ad6c9dc164dbfe32bb992cb96423c8 /integration_tests | |
| parent | 394c52260e861e911e2d8706d4904136a920da87 (diff) | |
break!: emit chars instead of strings
The HTML spec specifies that the tokenizer emits character tokens.
That html5gum always emitted strings instead was probably just done
to make the token consumption more convenient. When it comes to tree
construction character tokens are however actually more convenient
than string tokens since the spec defines that specific character
tokens should be ignored in specific states (and character tokens
let us avoid string manipulation for these conditions).
This should also make the DefaultEmitter more performant for cases
where you don't actually need the strings at all (or only a few)
since it avoids string allocations. Though I haven't benchmarked it.
Diffstat (limited to 'integration_tests')
| -rw-r--r-- | integration_tests/tests/test_html5lib.rs | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/integration_tests/tests/test_html5lib.rs b/integration_tests/tests/test_html5lib.rs index 2e404c5..bede29a 100644 --- a/integration_tests/tests/test_html5lib.rs +++ b/integration_tests/tests/test_html5lib.rs @@ -137,7 +137,14 @@ fn run_test_inner<R: Reader>( self_closing: tag.self_closing, }), Token::EndTag(tag) => actual_tokens.push(TestToken::EndTag { name: tag.name }), - Token::String(data) => actual_tokens.push(TestToken::Character(data)), + Token::Char(c) => { + // Coalesce all adjacent character tokens into a single string. + if let Some(TestToken::Character(s)) = actual_tokens.last_mut() { + s.push(c); + } else { + actual_tokens.push(TestToken::Character(c.into())); + } + } Token::Comment(comment) => actual_tokens.push(TestToken::Comment(comment.data)), Token::Doctype(doctype) => actual_tokens.push(TestToken::Doctype { name: doctype.name, |