Age | Commit message (Collapse) | Author | |
---|---|---|---|
2023-09-12 | docs: move warning from DefaultEmitter to Tokenizer | Martin Fischer | |
2023-09-11 | chore: move DefaultEmitter to own module | Martin Fischer | |
2023-09-09 | refactor: merge token types with attr to new token module | Martin Fischer | |
2023-09-09 | chore: group public modules together | Martin Fischer | |
2023-09-09 | docs: stop referencing Emitter from token types | Martin Fischer | |
2023-09-05 | docs: fix heading style in changelog | Martin Fischer | |
2023-09-05 | fix(docs): Comment data_offset field was changed | Martin Fischer | |
I forgot to document this breaking change in e993f19c2b8ef00b32f17f9ed32306f3ceb21bc3. | |||
2023-09-03 | chore: bump version to 0.5.1v0.5.1 | Martin Fischer | |
2023-09-03 | chore: bump edition to 2021 | Martin Fischer | |
2023-09-03 | chore: add categories to Cargo.toml | Martin Fischer | |
2023-09-03 | docs: add spans example | Martin Fischer | |
2023-09-03 | feat: add Doctype::name_span | Martin Fischer | |
2023-09-03 | break!: make Doctype name field optional | Martin Fischer | |
2023-09-03 | refactor: make test_and_annotate test encoding-independence | Martin Fischer | |
2023-09-03 | docs: the span logic no longer assumes UTF-8 | Martin Fischer | |
2023-09-03 | fix!: make comment data spans encoding-independent | Martin Fischer | |
2023-09-03 | test: test comment data spans more thoroughly | Martin Fischer | |
2023-09-03 | fix: make doctype id spans encoding-independent | Martin Fischer | |
2023-09-03 | fix!: make set_self_closing encoding-independent | Martin Fischer | |
2023-09-03 | fix!: make attribute spans encoding-independent | Martin Fischer | |
2023-09-03 | fix!: make start/end tag name spans encoding-independent | Martin Fischer | |
2023-09-03 | fix: don't assume UTF-8 in machine/tokenizer | Martin Fischer | |
2023-09-03 | refactor: inline internal method only used once | Martin Fischer | |
2023-09-03 | test: verify that span logic incorrectly assumes UTF-8 | Martin Fischer | |
2023-09-03 | refactor: make span tests tokenizer-independent | Martin Fischer | |
2023-09-03 | refactor: let comment and doctype tests check multiple cases | Martin Fischer | |
2023-09-03 | fix!: make PosTrackingReader encoding-independent | Martin Fischer | |
While much of the span logic currently assumes UTF-8, we also want to support other character encodings, such as e.g. UTF-16 where characters can take up more or less bytes than in UTF-8. | |||
2023-09-03 | refactor: also use some_offset for start/end tags | Martin Fischer | |
2023-09-03 | fix!: calculate tag offsets in Tokenizer instead of Emitter impl | Martin Fischer | |
2023-09-03 | fix: too small char ref error spans | Martin Fischer | |
2023-09-03 | chore: rename doctype_offset field to some_offset | Martin Fischer | |
We'll reuse the field for another offset in the next commit. | |||
2023-09-03 | refactor: proxy init_doctype through Tokenizer | Martin Fischer | |
2023-09-03 | test: verify too small char ref error spans | Martin Fischer | |
2023-09-03 | fix: off-by-one missing-semicolon-after-character-reference span | Martin Fischer | |
2023-09-03 | test: verify off-by-one missing-semicolon-after-character-reference span | Martin Fischer | |
2023-09-03 | chore: rename char ref test | Martin Fischer | |
The tests for character reference errors should be grouped together. So this commit puts "char_ref" first in the function name (since our error tests are ordered by function name). | |||
2023-09-03 | fix!: off-by-one end-tag-with-trailing-solidus span | Martin Fischer | |
2023-09-03 | fix: most error spans mistakenly being empty | Martin Fischer | |
With codespan_reporting an empty span shows up exactly like a one-byte span, which is why I didn't notice this mistake earlier. | |||
2023-09-03 | fix: off-by-one eof error spans | Martin Fischer | |
2023-09-03 | test: add span tests for eof errors | Martin Fischer | |
2023-09-03 | break!: make Emitter::emit_error take span | Martin Fischer | |
2023-09-03 | fix!: wrong attribute value spans for char refs | Martin Fischer | |
2023-09-03 | chore: move allow lint check attribute | Martin Fischer | |
2023-09-03 | //: fix outdated internal doc comment | Martin Fischer | |
2023-09-03 | test: verify wrong attribute value spans for char refs | Martin Fischer | |
2023-09-03 | docs: document character reference resolution | Martin Fischer | |
2023-09-03 | docs: document what has been ASCII-lowercased | Martin Fischer | |
2023-09-03 | docs: add example for NaiveParser's CDATA handling | Martin Fischer | |
2023-09-03 | feat: make DefaultEmitter public again | Martin Fischer | |
2023-09-03 | fix!: remove adjusted_current_node_present_and_not_in_html_namespace | Martin Fischer | |
Conceptually the tokenizer emits tokens, which are then handled in the tree construction stage (which this crate doesn't yet implement). While the tokenizer can operate almost entirely based on its state (which may be changed via Tokenizer::set_state) and its internal state, there is the exception of the 'Markup declaration open state'[1], the third condition of which depends on the "adjusted current node", which in turn depends on the "stack of open elements" only known to the tree constructor. In 82898967320f90116bbc686ab7ffc2f61ff456c4 I tried to address this by adding the adjusted_current_node_present_and_not_in_html_namespace method to the Emitter trait. What I missed was that adding this method to the Emitter trait effectively crippled the composability of the API. You should be able to do the following: struct TreeConstructor<R, O> { tokenizer: Tokenizer<R, O, SomeEmitter<O>>, stack_of_open_elements: Vec<NodeId>, // ... } However this doesn't work if the implementation of SomeEmitter depends on the stack_of_open_elements field. This commits remedies this oversight by removing this method and instead making the Tokenizer yield values of a new Event enum: enum Event<T> { Token(T), CdataOpen } Event::CdataOpen signals that the new Tokenizer::handle_cdata_open method has to be called, which accepts a CdataAction: enum CdataAction { Cdata, BogusComment } the variants of which correspond exactly to the possible outcomes of the third condition of the 'Markup declaration open state'. Removing this method also has the added benefit that the DefaultEmitter is now again spec-compliant, which lets us expose it again in the next commit in good conscience (previously it just hard-coded the method implementation to return false, which is why I had removed the DefaultEmitter from the public API in the last release). [1]: https://html.spec.whatwg.org/multipage/parsing.html#markup-declaration-open-state |