From 4603102722e1cc2abc3494c9446bc576d008e7fa Mon Sep 17 00:00:00 2001 From: Richard Walters Date: Wed, 4 Jul 2018 16:12:45 -0700 Subject: Fix bug in truncated host elements For example, "[::1", where the square bracket at the end is missing. Handle truncated host element by checking the state we end up in after the entire string is parsed. Some states represent interal elements of a host name or address, and so if we're still in those states and run out of input characters, the input string was cut off early. --- src/Uri.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/Uri.cpp b/src/Uri.cpp index 56889b7..dbc9ff6 100644 --- a/src/Uri.cpp +++ b/src/Uri.cpp @@ -741,6 +741,15 @@ namespace Uri { } break; } } + if ( + (hostParsingState != HostParsingState::FIRST_CHARACTER) + && (hostParsingState != HostParsingState::NOT_IP_LITERAL) + && (hostParsingState != HostParsingState::GARBAGE_CHECK) + && (hostParsingState != HostParsingState::PORT) + ) { + // truncated or ended early + return false; + } if (hostIsRegName) { host = NormalizeCaseInsensitiveString(host); } -- cgit v1.2.3